Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase blinded block submission timeout from 1s to 4s #4088

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Conversation

tersec
Copy link
Contributor

@tersec tersec commented Sep 7, 2022

At this point, why not -- one can't fallback to a local EL anymore.

BUILDER_BLOCK_SUBMISSION_DELAY_TOLERANCE = 1.seconds
BUILDER_BLOCK_SUBMISSION_DELAY_TOLERANCE = 4.seconds
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be tied to INTERVALS_PER_SLOT to take account for faster slots on e.g. gnosis?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still better to try to propose. As long as it's less than slot time, it's fine.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't leave any time for the empty block to propagate, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What empty block? It's too late for any kind of local fallback, empty or otherwise, by this point. To quote https://nimbus.guide/external-block-builder.html

There exists a failure mode, intrinsic to the builder API, wherein the consensus client has signed a blinded proposal and therefore even if the external block builder relay or builder doesn't provide a full block, a consensus client such as Nimbus cannot safely proceed with step 2 and fall back on its local execution client.

"Safely proceed" == "without high risk of slashing".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, this is for when we've already signed it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@tersec tersec enabled auto-merge (squash) September 7, 2022 12:08
@arnetheduck arnetheduck disabled auto-merge September 7, 2022 16:52
@arnetheduck arnetheduck merged commit 324e021 into unstable Sep 7, 2022
@arnetheduck arnetheduck deleted the FCF branch September 7, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants