persist LC data across restarts #3823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the Altair spec `LightClientUpdate` structure taking its final form it is finally possible to persist LC data across restarts without having to worry about data migration due to spec changes. A separate `lcdataV1` database is created in the `caches` subdirectory to hold known LC data. A full database with default settings (129 periods) uses <15 MB disk.
|
lcdataV1.sqlite3.zip |
tersec
reviewed
Jun 29, 2022
tersec
reviewed
Jun 29, 2022
tersec
reviewed
Jun 29, 2022
tersec
reviewed
Jun 29, 2022
|
why keep this in a separate database? this is supposed to be part of the "standard feature set" of every beacon node running the full protocol, so it should really live in the main db, no? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the Altair spec
LightClientUpdatestructure taking its final formit is finally possible to persist LC data across restarts without having
to worry about data migration due to spec changes. A separate
lcdataV1database is created in the
cachessubdirectory to hold known LC data.A full database with default settings (129 periods) uses <15 MB disk.