more 0.7.0 updates #287
Merged
more 0.7.0 updates #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wards_and_penalties(...) to 0.7.0
…et_domain to update get_domain(...) to 0.7.0; mark that mainnet constant presets and block header processing are 0.7.0-consistent; update process_justification_and_finalization to 0.7.0 to fix potential underflow errors
mratsim
approved these changes
Jun 14, 2019
| buf[0..3] = fork_version | ||
| buf[4..7] = int_to_bytes4(domain_type.uint64) | ||
| bytes_to_int(buf) | ||
|
|
There was a problem hiding this comment.
I would had a TODO: Big-endian architecture in a comment.
There was a problem hiding this comment.
int_to_bytes4 already is defined in explicit terms as little-endian in https://github.com/ethereum/eth2.0-specs/blob/v0.7.0/specs/core/0_beacon-chain.md#int_to_bytes (0.7.0 version) and https://github.com/ethereum/eth2.0-specs/blob/v0.6.3/specs/core/0_beacon-chain.md#int_to_bytes1-int_to_bytes2- (0.6.3 version).
There was a problem hiding this comment.
Likewise, bytes_to_int
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.