Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup nat traversal files #1554

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Cleanup nat traversal files #1554

merged 1 commit into from
Aug 28, 2020

Conversation

zedeus
Copy link
Contributor

@zedeus zedeus commented Aug 21, 2020

Preparation for ARMv7 cross compilation along with status-im/nim-nat-traversal#3

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@stefantalpalaru
Copy link
Contributor

Why not add those lines to the "clean" target?

@zedeus
Copy link
Contributor Author

zedeus commented Aug 21, 2020

I noticed this is already done here https://github.com/status-im/nimbus-build-system/blob/master/makefiles/targets.mk#L116, and running make clean also results in having to recompile Nim, so I moved it to a separate task to save time when moving between platforms

@stefantalpalaru stefantalpalaru merged commit f250012 into status-im:devel Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants