Rework pubsub #1474
Closed
Rework pubsub #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is apparently not rebased to current |
|
You also need a nim-stew bump. |
arnetheduck
force-pushed
the
rework-pubsub
branch
3 times, most recently
from
5db23f7 to
d005d31
Compare
|
There's a drastic improvement in the libp2p stream (and associated futures) leaks. |
Merged
arnetheduck
force-pushed
the
rework-pubsub
branch
2 times, most recently
from
353ba34 to
1570caf
Compare
arnetheduck
force-pushed
the
rework-pubsub
branch
from
1570caf to
313cded
Compare
|
Merged here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This consumes the split out pubsub from vacp2p/nim-libp2p#322, most things work and it's a big improvement over past versions. Please give it a try.