Coredb fix kvt save only fringe condition #2592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
why: If `Kvt` is tied to the `Aristo` DB save cycle, then this save cycle must also be committed if there is no data to save for `Aristo`. Otherwise this will lead to excessive core memory use with some fringe condition where Eth headers (or blocks) are downloaded while syncing and not really stored on disk.
why: Saving `Kvt` first is seen as a harbinger (or canary) for `Aristo` as both run in sync. If `Kvt` succeeds saving first, so must be `Aristo` next. Other than this is a defect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.