compilation should fail if wrong nim_commit was specified #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, the CIs are all failing. But conceptually I agree with this change. |
cskiraly
force-pushed
the
fix-silent-checkout-failure
branch
from
f247823 to
536311a
Compare
Previously there was an error message, but then compilation went on with another Nim version. Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
cskiraly
force-pushed
the
fix-silent-checkout-failure
branch
from
536311a to
d0e2138
Compare
|
Should be better now, but let's wait it out. |
tersec
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if there was an unavailable version specified, there was an error message, but then compilation went on using another Nim version.