fix: don't require user hash match for full checksum (#444)

statsig-io · Feb 15, 2025 · a93a832 · a93a832
1 parent b2d5dbd
commit a93a832
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 8 deletions.
diff --git a/packages/client-core/src/DataAdapterCore.ts b/packages/client-core/src/DataAdapterCore.ts
@@ -110,6 +110,7 @@ export abstract class DataAdapterCore {
     current: string | null,
     user?: StatsigUser,
     options?: DataAdapterAsyncOptions,
+    isCacheValidFor204?: boolean,
   ): Promise<string | null>;
 
   protected abstract _getCacheKey(user?: StatsigUserInternal): string;
@@ -124,12 +125,17 @@ export abstract class DataAdapterCore {
     user: StatsigUserInternal | undefined,
     options: DataAdapterAsyncOptions | undefined,
   ): Promise<DataAdapterResult | null> {
-    let cachedData: string | null = null;
-    if (cachedResult && this._isCachedResultValidFor204(cachedResult, user)) {
-      cachedData = cachedResult.data;
-    }
-
-    const latest = await this._fetchFromNetwork(cachedData, user, options);
+    const cachedData: string | null = cachedResult?.data ?? null;
+    const isCacheValidFor204 =
+      cachedResult != null &&
+      this._isCachedResultValidFor204(cachedResult, user);
+
+    const latest = await this._fetchFromNetwork(
+      cachedData,
+      user,
+      options,
+      isCacheValidFor204,
+    );
     if (!latest) {
       Log.debug('No response returned for latest value');
       return null;

diff --git a/packages/js-client/src/Network.ts b/packages/js-client/src/Network.ts
@@ -44,6 +44,7 @@ export default class StatsigNetwork extends NetworkCore {
     current: string | null,
     priority?: NetworkPriority,
     user?: StatsigUser,
+    isCacheValidFor204?: boolean,
   ): Promise<string | null> {
     const cache = current
       ? _typedJsonParse<InitializeResponse>(
@@ -63,9 +64,11 @@ export default class StatsigNetwork extends NetworkCore {
     if (cache?.has_updates) {
       data = {
         ...data,
-        sinceTime: cache.time,
+        sinceTime: isCacheValidFor204 ? cache.time : 0,
         previousDerivedFields:
-          'derived_fields' in cache ? cache.derived_fields : {},
+          'derived_fields' in cache && isCacheValidFor204
+            ? cache.derived_fields
+            : {},
         deltasResponseRequested: true,
         full_checksum: cache.full_checksum,
       };

diff --git a/packages/js-client/src/StatsigEvaluationsDataAdapter.ts b/packages/js-client/src/StatsigEvaluationsDataAdapter.ts
@@ -76,12 +76,14 @@ export class StatsigEvaluationsDataAdapter
     current: string | null,
     user?: StatsigUser,
     options?: DataAdapterAsyncOptions,
+    isCacheValidFor204?: boolean,
   ): Promise<string | null> {
     const result = await this._network?.fetchEvaluations(
       this._getSdkKey(),
       current,
       options?.priority,
       user,
+      isCacheValidFor204,
     );
     return result ?? null;
   }