Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New get latest path #107

Merged
merged 20 commits into from
Oct 28, 2024
Merged

New get latest path #107

merged 20 commits into from
Oct 28, 2024

Conversation

aecorn
Copy link
Collaborator

@aecorn aecorn commented Oct 24, 2024 •
edited
Loading

Revision of the existing code is needed firstly because:

  • Sorting alphabetically will place v2 later than v11
  • Looking for existing versions in Dapla Lab using the prefix gs:// was not finding any files, so there's a danger of overwriting v1 of files. Reported by @mfmssb

@aecorn aecorn requested review from efredborg and sebrothe October 24, 2024 05:44
@aecorn aecorn marked this pull request as draft October 24, 2024 05:44
@aecorn aecorn added bug Something isn't working refactoring Refactoring labels Oct 24, 2024
@sebrothe sebrothe marked this pull request as ready for review October 28, 2024 08:05
sebrothe
sebrothe previously approved these changes Oct 28, 2024
View reviewed changes
@sebrothe sebrothe requested a review from akcssb October 28, 2024 11:18
@aecorn aecorn requested a review from sebrothe October 28, 2024 11:44
akcssb
akcssb previously approved these changes Oct 28, 2024
View reviewed changes
@akcssb akcssb self-requested a review October 28, 2024 11:47
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@aecorn aecorn merged commit 8c449e9 into main Oct 28, 2024
16 checks passed
@aecorn aecorn deleted the new_get_latest_path branch October 28, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akcssb akcssb akcssb approved these changes

@efredborg efredborg Awaiting requested review from efredborg efredborg is a code owner

@sebrothe sebrothe Awaiting requested review from sebrothe

Assignees

@sebrothe sebrothe

Labels
bug Something isn't working refactoring Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aecorn @akcssb @sebrothe