Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for daplalab #104

Merged
merged 5 commits into from
Oct 15, 2024
Merged

fix for daplalab #104

merged 5 commits into from
Oct 15, 2024

Conversation

akcssb
Copy link
Contributor

@akcssb akcssb commented Oct 10, 2024

No description provided.

@akcssb akcssb requested review from aecorn and Jonathan7SSB October 10, 2024 13:57
@aecorn
Copy link
Collaborator

aecorn commented Oct 14, 2024 •
edited
Loading

You are using a new "get_dapla_region", that is not present in older versions of dapla-toolbelt. You must require a version of dapla-toolbelt that contains the used method.

aecorn
aecorn approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@aecorn aecorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the changes I made, especially tabbing out the contents of check_env, to run, even without an attributeError

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@akcssb akcssb merged commit 072ed74 into main Oct 15, 2024
16 checks passed
@akcssb akcssb deleted the fix-check-env branch October 15, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aecorn aecorn aecorn approved these changes

@Jonathan7SSB Jonathan7SSB Awaiting requested review from Jonathan7SSB Jonathan7SSB is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akcssb @aecorn