Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to address issue 662 - https://github.com/Wyamio/Wyam/issues/662 #663

Closed
wants to merge 1 commit into from

Conversation

rpriest1260
Copy link

There are build systems that block access to "outside" NuGet sources.
Therefore, the hard-coded DefaultSources list in
SourceRepositoryProvider.cs presents a problem when trying to generate
documentation. There seems to be no way to opt out of using
"https://api.nuget.org/v3/index.json".
This fix removes this hard-coded value and leaves the decision to the
user via their NuGet.config setup or their WyamSettings specifications
(setting of NugetSources and UseGlobalSources).

There are build systems that block access to "outside" NuGet sources.
Therefore, the hard-coded DefaultSources list in
SourceRepositoryProvider.cs presents a problem when trying to generate
documentation. There seems to be no way to opt out of using
"https://api.nuget.org/v3/index.json".
This fix removes this hard-coded value and leaves the decision to the
user via their NuGet.config setup or their WyamSettings specifications
(setting of NugetSources and UseGlobalSources).
@daveaglick
Copy link
Member

Sorry, totally forgot that you submitted this PR. I've addressed this issue with a new --ignore-default-sources flag and a corresponding Wyam.Cake setting. The default gallery source will still be added by default, but that can be ignored with the flag. That should cover this use case. I don't want to spend too much time tweaking NuGet handling since Wyam isn't going to manage NuGet packages starting with 2.0 (see #668).

@daveaglick daveaglick closed this Jun 7, 2018
@rpriest1260
Copy link
Author

Fair enough. Having a way to ignore it in the WyamSettings should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants