Attemt at cleaning up nighty packaging after https://github.com/JuliaLang/julia/pull/5095 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticfloat
added a commit
that referenced
this pull request
Dec 15, 2013
Attemt at cleaning up nighty packaging after JuliaLang/julia#5095
|
Awesome, thanks for the PR! |
|
I think that you should have waited until the Julia PR was merged before merging this. Now your nightly builds will fail. :( |
|
This is actually the second time I've committed something to this repository thinking that that particular PR was already merged. I guess I'm just so excited to not have to maintain the |
|
I planned to write something to indicate that it wasn't ready to merge, but obviously I forgot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hope this is correct and works. I have not tried it, but the changes seem obvious.