-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow updating the pyenv global versions file #204
Allow updating the pyenv global versions file #204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just removing lint error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind fixing also these lint issues that showed up so can take a deeper look when pipeline are passing?
Thanks a lot for finding this and pointing this out! I will take a look into it very soon, meanwhile I saw some linting issues if you could check would be great. |
Linting errors should be fixed now! |
Thanks a lot, approved. |
Hello,
When setting the value of the
pyenv_global
variable to a different value than contained in the"{{ pyenv_path }}/version"
file, the global version file is not updated. This is probably because of the following condition : https://github.com/staticdev/ansible-role-pyenv/blob/main/tasks/install.yml#L91 which skips running the command when the file already exists (https://docs.ansible.com/ansible/latest/collections/ansible/builtin/shell_module.html#parameter-creates)We could remove that condition altogether, but this would always modify the file. We could also print & parse the globals as shown in this PR.
Let me know what you think!
(Also, thank you so much for maintaining this plugin!)