Added lint to molecule

[MorganLindqvist]

Added so that the lint test is always run when using molecule

Change-Id: I537aa1a622a8dc0a85b181f14c3eb709df8d8477

[MorganLindqvist]

Since the code fails lint the addition of lint tests in molecule will fail. Fixing the faults or explicitly disabling them in the code will make this PR work and keep future molecule tests fail if the code fails lint.

[MorganLindqvist]

@staticdev Now fixed all lint warnings in the code. Looks like there is somethiing in the CI/CD chain in github that makes it fail anyway. Any ideas?

[MorganLindqvist]

Hi @staticdev ,
I added so that lint is done every time one runs molecule.

Lint then need to be added in the test.yml file (I can do this). Would you like this or to remove lint from being run default every time one builds with molecule?

I would prefer it being run every time one run molecule but it is your repository.

[staticdev]

What are the advantages of having it on molecule in this case? I added a separate lint workflow because with molecule the same checks were repeated in each distro for molecule, resulting in longer wait in Github Actions. Am I missing something?

[MorganLindqvist]

@staticdev the benefit would be that one would always run the linting everyting one run molecule during development on the local computer and could fix lint issues as soon as they occur whithout needing the extra step of running lint explicitly.

[staticdev]

@MorganLindqvist I understand your point but for me does not justify the time on pipeline. With precommit I forget about lint and focus on my change while developing, then I worry when I do the commits. Also for me is bad to change one role to lint different since I have a standard already for many roles. Hope you can also see my side since I have extra costs involved to maintain the role.

[MorganLindqvist]

@staticdev sure, will remove lint from the molecule build

[staticdev]

Thanks a lot @MorganLindqvist ! LGTM.