possible to specify where to deploy pyenvrc file #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticdev
requested changes
Jan 4, 2023
There was a problem hiding this comment.
@MorganLindqvist thanks a lot for your contribution and sorry for taking long to respond. Actually I did some work in parallel that conflicted. I would suggest you if possible to rebase your branch and rename the new parameter to pyenvrc_path this will be clear for the users since it exact name.
…r than pyenv_path Change-Id: I79d7aec3be083ead6e09630da6ebaa7c35fd0311
Change-Id: Ib22ba6e03c23cb546af562b8d101fbaee5e41874
|
Rebased and parameter name changed as requested |
staticdev
approved these changes
Jan 7, 2023
|
@MorganLindqvist LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the pyenvrc file was placed in the pyenv root folder, this pollutes the git context.
Change enables placing the pyenvrc file in a different location, default is old location.