Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug-fix: return value #54

Merged
merged 1 commit into from
Nov 15, 2023
Merged

bug-fix: return value #54

merged 1 commit into from
Nov 15, 2023

Conversation

realizm
Copy link
Collaborator

@realizm realizm commented Nov 15, 2023

bug-fix: transcribe_api_endpoint return value

@github-actions GitHub Actions
Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

@realizm
Copy link
Collaborator Author

realizm commented Nov 15, 2023

I have read the CLA Document and I hereby sign the CLA

@realizm
Copy link
Collaborator Author

realizm commented Nov 15, 2023

CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

I have read the CLA Document and I hereby sign the CLA

MinDongRyul
MinDongRyul approved these changes Nov 15, 2023
View reviewed changes
fastapi_backend/server.py
return {"transcription": transcription}
#bug-fix, tjkim
#return {"transcription": transcription}
return {"transcription": transcript}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return value name을 수정해주셔서 감사합니다.

@MinDongRyul MinDongRyul merged commit 890c7f4 into main Nov 15, 2023
1 check failed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2023
@MinDongRyul MinDongRyul deleted the tjkim branch November 15, 2023 05:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MinDongRyul MinDongRyul MinDongRyul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@realizm @MinDongRyul @Kim-taejung