Pass self to context factories
#4616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 97d7f8a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 97d7f8a:
|
davidkpiano
reviewed
Dec 22, 2023
| @@ -697,6 +697,11 @@ export class Actor<TLogic extends AnyActorLogic> | |||
| * @see {@link Actor.getPersistedSnapshot} to persist the internal state of an actor (which is more than just a snapshot). | |||
| */ | |||
| public getSnapshot(): SnapshotFrom<TLogic> { | |||
| if (isDevelopment && !this._snapshot) { | |||
| throw new Error( | |||
| `Snapshot can't be read while the actor initializes itself` | |||
There was a problem hiding this comment.
Suggested change
| `Snapshot can't be read while the actor initializes itself` | |
| `Snapshot cannot be read before actor is being initialized.` |
There was a problem hiding this comment.
The suggested change is not correct. This is perfectly valid:
const actorRef = createActor(machine)
actorRef.getSnapshot()
actorRef.start()This isn't:
const machine = createMachine({
context: ({ self }) => {
self.getSnapshot() // we can't do this
return {}
}
})
createActor(machine)
davidkpiano
approved these changes
Dec 22, 2023
Merged
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4612