Minor Fix to todomvc-react Example Project #4580
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I hope I'm not stepping out of line here but I had pulled down the
xstate
repo to help myself learn about the library in more detail and attempted to runexamples/todomvc-react
but found a few minor issues related to the v5 upgrade:• Initially, running
pnpm run dev
resulted in the error:Pinning
xstate-react
at^4.0.0
rather thanbeta
resolved this issue.• On using the example app re-opening the page caused a failure due to the change in state persistence method from
getPersistedState()
togetPersistedSnapshot ()
. Moving to the new method name appears to resolve the issue.I hope this PR is useful. Obviously, please let me know if there are any stylistic changes needed in order to make it a candidate to merge. I have not created a change set as that didn't seem appropriate for an example?