runtime: implement building image in Docker runtime #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adambabik
force-pushed
the
adamb/finish-impl-run-in-docker
branch
from
6406644 to
2324588
Compare
adambabik
force-pushed
the
adamb/finish-impl-run-in-docker
branch
from
2324588 to
4b6e794
Compare
adambabik
commented
Mar 10, 2025
| @@ -47,7 +47,7 @@ project: | |||
| runtime: | |||
| # Optional Docker configuration to run code blocks in a container. | |||
| docker: | |||
| enabled: false | |||
| enabled: true | |||
There was a problem hiding this comment.
TODO: Remove before merge.
adambabik
commented
Mar 10, 2025
| @@ -130,11 +130,6 @@ func (sl *Cache[T]) Newest() (T, bool) { | |||
| return element.Value.(*listEntry[T]).entry, true | |||
| } | |||
|
|
|||
| // Deprecated: Use Newest instead. | |||
There was a problem hiding this comment.
TODO: Move it to a separate PR.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an ability to build a Docker image in Docker runtime. With
runtime.docker.enabled = true, it should be possible to execute commands from Markdown files.There are still limitations, for example, it's not possible to share env between commands.