Replace golang.org/x/exp with stdlib
#759
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These experimental packages are now available in the Go standard library. 1. golang.org/x/exp/slices -> slices [1] 2. golang.org/x/exp/rand -> math/rand/v2 [2] golang.org/x/exp/rand has been deprecated and scheduled to be deleted [3]. [1]: https://go.dev/doc/go1.21#slices [2]: https://go.dev/doc/go1.22#math_rand_v2 [3]: golang/exp@f9890c6 Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
adambabik
requested changes
Mar 9, 2025
|
Thanks for the contribution! I requested to stay with |
Juneezee
added a commit
to Juneezee/runme
that referenced
this pull request
Mar 9, 2025
Reference: stateful#759 (review) Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Reference: stateful#759 (review) Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
It uses math/rand and LockedMonotonicReader internally, which is exactly the same code as ours. Reference: https://github.com/oklog/ulid/blob/v2.1.0/ulid.go#L132-L140 Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Juneezee
commented
Mar 9, 2025
| @@ -60,7 +37,7 @@ func GenerateID() string { | |||
| } | |||
|
|
|||
| func DefaultGenerator() string { | |||
| entropy := DefaultEntropy() | |||
| entropy := ulid.DefaultEntropy() | |||
There was a problem hiding this comment.
After applying the code suggestion #759 (comment), I realize that we can use the DefaultEntropy() function from github.com/oklog/ulid/v2 since it also uses math/rand and LockedMonotonicReader internally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These experimental packages are now available in the Go standard library.
golang.org/x/exp/slices->slices(https://go.dev/doc/go1.21#slices)golang.org/x/exp/rand->math/rand/v2(https://go.dev/doc/go1.22#math_rand_v2)golang.org/x/exp/randhas been deprecated and scheduled to be deleted.Reference: golang/exp@f9890c6