document: clean up attributes parsing #732
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adambabik
force-pushed
the
adamb/cleanup-attributes-parsing
branch
from
653731d to
44b5d59
Compare
|
| // | ||
| // Pioneered by Adam Babik | ||
| type babikMLParser struct{} | ||
| // Deprecated: Use the JSON parser instead. |
There was a problem hiding this comment.
I wouldn't say it's deprecated. It's just not the default.
sourishkrout
requested changes
Jan 28, 2025
There was a problem hiding this comment.
I'm almost done with a PR using this as a base to retain whatever Attribute Encoding was parsed. We've been having issues breaking Hugo sites with JSON encoding.
Will send the PR shortly.
|
@adambabik please see #735, which is built on top of this PR. |
|
Replaced with #735. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.