Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shell dry-run output should be runable #729

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

lalyos
Copy link
Contributor

@lalyos lalyos commented Jan 18, 2025

I've redirected the output of runme run --dry-run into a file.
The code block was of bash type and the file nicely starts with shebang:

#!/usr/local/bin/bash

// run in "/Users/lalyos/somedir"

set -e -o pipefail
echo hello

the run in "dir" line supposed to be a comment, but the syntax doesn't fit shell syntax.

Copy link
Collaborator

@adambabik adambabik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for the contribution, LGTM!

@adambabik
Copy link
Collaborator

@lalyos it seems that this PR is out of date. Could you rebase it on the main branch?

@lalyos
Copy link
Contributor Author

lalyos commented Jan 23, 2025

@adambabik rebased

@sourishkrout sourishkrout merged commit a04f98b into stateful:main Jan 24, 2025
6 checks passed
@sourishkrout
Copy link
Member

sourishkrout commented Jan 27, 2025

This change was included in https://github.com/stateful/runme/releases/tag/v3.11.0, @lalyos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants