Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details to vignettes about corncob plotting functions #180

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

gthopkins
Copy link
Contributor

I am responding to issue #144 to describe the plotting functions in more detail, and also describing how to access data from the functions so users can create custom plots.

I am responding to issue statdivlab#144 to describe the plotting functions in more detail, and also describing how to access data from the functions so users can create custom plots.
I am responding to the failed checks on PR statdivlab#180, which I think were caused by mutate() not being called dplyr::mutate().
Copy link
Collaborator

@svteichman svteichman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the no phyloseq vignette, it seems that the phrase "the points represent the relative abundances" is repeated once in line 121 and once in 122. If this is the case, can you remove the second version? Otherwise it looks good to me!

I mistakenly edited the vignette without phyloseq to repeated the sentence "The points represent the relative abundances" in PR statdivlab#180. The duplicate is now removed and the formatting is identical between vignettes.
@gthopkins
Copy link
Contributor Author

Thank you @svteichman for catching the typo I introduced! I corrected it and once this passes checks again I will merge.

@gthopkins gthopkins merged commit a0309c5 into statdivlab:main Sep 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants