-
-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multisite: Propagate date change to descendants #6634
Multisite: Propagate date change to descendants #6634
Conversation
Where should the tests for these changes go? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the propagating should be happening in Entry@save
, just like the other propagating stuff.
That way, it can happen if you were to save programmatically instead of only in the control panel.
The tests can go into EntryTest. There are other propagation tests in there.
This works, thanks for making the changes. However after thinking about it some more, I don't think it should work this way. Nowhere else do we forcibly update the descendants. I think the real fix should be something more inline with how origin fallback values work for all other fields. |
Makes total sense. |
This fixes #3440.
I made these choices:
* Note that this won't take into account if the (custom) date field has been desynced. The date will be copied regardless.