Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track and handle hidden fields on publish forms to fix sometimes, required_if, etc. rules #5101

Merged
merged 11 commits into from
Jan 25, 2022
Merged

Track and handle hidden fields on publish forms to fix sometimes, required_if, etc. rules #5101

merged 11 commits into from
Jan 25, 2022

Conversation

jesseleite
Copy link
Member

@jesseleite jesseleite commented Jan 20, 2022 •
edited
Loading

Closes #5092.

TODO:

  • Track hidden fields as we evaluate showField() logic on each publish form field.
  • Refactor to use dynamic publish store name, rather than hardcoding to base.
  • Remove setTrackMissingValues() from Fields.php and always track missing values when calling addValues().
  • Ensure we filter payloads on every publish form before sending to server.
  • Add test coverage.
  • Handle nested missing values within grids/replicators/bards.
    • We can revisit this in another PR after @arthurperton finishes his grid/replicator/bard validation related fixes 👍

@jesseleite jesseleite requested a review from jasonvarga January 21, 2022 22:08
@jesseleite jesseleite marked this pull request as ready for review January 21, 2022 22:09
@jesseleite jesseleite mentioned this pull request Jan 24, 2022
Merged
22 tasks
@jesseleite jesseleite merged commit 7e06a58 into feature/frontend-form-conditions Jan 25, 2022
@jesseleite jesseleite deleted the fix/missing-publish-form-values-for-sometimes-rule branch January 25, 2022 19:21
jasonvarga added a commit that referenced this pull request Jan 27, 2022
@jesseleite @jasonvarga @StyleCIBot
Frontend form field conditions ... (#4949)
4632bbf 
...and CP forms only submit visible fields, in order to fix sometimes/required_if/etc validation rules. (#5101)

Co-authored-by: Jason Varga <jasonvarga@users.noreply.github.com>
Co-authored-by: StyleCI Bot <bot@styleci.io>
Co-authored-by: Jason Varga <jason@pixelfear.com>
@jesseleite jesseleite mentioned this pull request Apr 13, 2022
Merged
8 tasks
@duncanmcclean duncanmcclean mentioned this pull request Dec 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonvarga jasonvarga Awaiting requested review from jasonvarga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jesseleite @jasonvarga