Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Prettier #11415

Merged
merged 16 commits into from
Feb 5, 2025
Merged

[6.x] Prettier #11415

merged 16 commits into from
Feb 5, 2025

Conversation

jasonvarga
Copy link
Member

@jasonvarga jasonvarga commented Feb 4, 2025

This PR adds Prettier in order to lint and fix code style issues across the whole app.

Pint continues to be used for PHP, but now Prettier will be used for JS, CSS, Blade, and Antlers.

This PR also disables the workflow that automatically fixes and commits any changes. We ran into an infinite commit loop and would like to avoid that happening again.

Ideally you would set up your code editor to leverage Prettier so it formats on save, but you can also run npm run prettier:format .

@jasonvarga
Copy link
Member Author

lol what have i done

@JohnathonKoster
Copy link
Contributor

What a ride

@jasonvarga jasonvarga marked this pull request as ready for review February 5, 2025 00:14
@jasonvarga
Copy link
Member Author

I'm merging this with the linting failing, and will apply the fixes in a separate PR so that we can add the commit to .git-blame-ignore-revs.

https://docs.github.com/en/repositories/working-with-files/using-files/viewing-and-understanding-files#ignore-commits-in-the-blame-view

@jasonvarga jasonvarga merged commit df6ea20 into master Feb 5, 2025
17 of 18 checks passed
@jasonvarga jasonvarga deleted the prettier branch February 5, 2025 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants