[5.x] Add a config for specifying the default layout #11025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonvarga
previously requested changes
Oct 29, 2024
There was a problem hiding this comment.
IMO if this setting exists it should also be used wherever we already use layouts too, like in a collection.
cms/src/Entries/Collection.php
Line 445 in d864fac
|
Cool. Time to grep ‘layout’. |
|
It's really just Collection@layout and Taxonomy@layout that have the string hardcoded. Change the config value and that should be good. |
|
Those are updated now. |
|
I moved the config into |
ryanmitchell
deleted the
feature/allow-default-layout-to-be-configured
branch
duncanmcclean
added a commit
to statamic/statamic
that referenced
this pull request
Nov 12, 2024
duncanmcclean
added a commit
to statamic/statamic
that referenced
this pull request
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new config
statamic.routes.layoutthat allow the default layout to be changed to something other thanlayout. I've also set it to look for an .env variable (STATAMIC_FRONTEND_ROUTES_LAYOUT).Our use is we have a site where the same codebase is shared across slightly different site versions and need to adapt the layout significantly per site - but other than that the codebase is the same.
If it helps make the case - Livewire allow the layout to be changed in a config.