[5.x] Throw 401 on password protected page #10947
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on a custom password-protected page design, I noticed that the flow felt a little off if a token is invalid or missing. It's common practice for signed URLs to throw a
401
if the signature is invalid.I understand that there's the
no_token
variable that can be used to display a message if the token is missing. However, it still feels a little weird to show a message to the user instead of aborting. Also, the current approach doesn't handle situations where a token is invalid. It only handles situations where the token parameter is missing altogether.This PR is technically a breaking change and should probably target Statamic 6.x.
A non-breaking change could be implemented with a new
abort
tag and throwing it in the view instead.