Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Paginate folders in asset browser #10419

Merged
merged 16 commits into from
Jul 10, 2024
2 changes: 1 addition & 1 deletion resources/js/components/assets/Browser/Browser.vue
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@
</td>
<td :colspan="columns.length" />
</tr>
<tr v-for="(folder, i) in folders" :key="folder.path" v-if="!restrictFolderNavigation && page === 1">
<tr v-for="(folder, i) in folders" :key="folder.path" v-if="!restrictFolderNavigation">
<td />
<td @click="selectFolder(folder.path)">
<a class="flex items-center cursor-pointer group">
Expand Down
61 changes: 51 additions & 10 deletions src/Http/Controllers/CP/Assets/BrowserController.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,15 @@
namespace Statamic\Http\Controllers\CP\Assets;

use Illuminate\Http\Request;
use Illuminate\Pagination\Paginator;
use Statamic\Contracts\Assets\AssetContainer as AssetContainerContract;
use Statamic\Exceptions\AuthorizationException;
use Statamic\Facades\Asset;
use Statamic\Facades\Scope;
use Statamic\Facades\User;
use Statamic\Http\Controllers\CP\CpController;
use Statamic\Http\Resources\CP\Assets\FolderAssetsCollection;
use Statamic\Http\Resources\CP\Assets\Folder;
use Statamic\Http\Resources\CP\Assets\FolderAsset;
use Statamic\Http\Resources\CP\Assets\SearchedAssetsCollection;
use Statamic\Support\Arr;

Expand Down Expand Up @@ -74,20 +76,59 @@ public function folder(Request $request, $container, $path = '/')
$this->authorize('view', $container);

$folder = $container->assetFolder($path);
$perPage = $request->perPage ?? config('statamic.cp.pagination_size');
$page = Paginator::resolveCurrentPage();

$query = $folder->queryAssets();
$folders = $folder->assetFolders();
$totalFolders = $folders->count();
$folders = $folders->slice(($page - 1) * $perPage, $perPage);
$lastFolderPage = (int) ceil($totalFolders / $perPage) ?: 1;

if ($request->sort) {
$query->orderBy($request->sort, $request->order ?? 'asc');
} else {
$query->orderBy($container->sortField(), $container->sortDirection());
}
$totalAssets = $folder->queryAssets()->count();
$totalItems = $totalAssets + $totalFolders;

$this->applyQueryScopes($query, $request->all());
if ($page >= $lastFolderPage) {
$query = $folder->queryAssets();

$assets = $query->paginate(request('perPage'));
if ($request->sort) {
$query->orderBy($request->sort, $request->order ?? 'asc');
} else {
$query->orderBy($container->sortField(), $container->sortDirection());
}

$this->applyQueryScopes($query, $request->all());

$offset = $page === $lastFolderPage
? 0
: $perPage * ($page - $lastFolderPage) - ($totalFolders % $perPage);

return (new FolderAssetsCollection($assets))->folder($folder);
$assets = $query
->offset($offset)
->limit($perPage - $folders->count())
->get();
}

return [
'data' => [
'assets' => FolderAsset::collection($assets ?? collect())->resolve(),
'folder' => array_merge((new Folder($folder))->resolve(), [
'folders' => $folders->values(),
]),
],
'links' => [
'asset_action' => cp_route('assets.actions.run'),
'folder_action' => cp_route('assets.folders.actions.run', $container->id()),
],
'meta' => [
'current_page' => $page,
'from' => $totalItems > 0 ? ($page - 1) * $perPage + 1 : null,
'last_page' => $totalItems > 0 ? max((int) ceil($totalItems / $perPage), 1) : null,
'path' => Paginator::resolveCurrentPath(),
'per_page' => $perPage,
'to' => $totalItems > 0 ? $page * $perPage : null,
'total' => $totalItems,
],
];
}

public function search(Request $request, $container, $path = null)
Expand Down
36 changes: 0 additions & 36 deletions src/Http/Resources/CP/Assets/FolderAssetsCollection.php

This file was deleted.

Loading