Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Add Publish State permission #553

Merged

Conversation

edalzell
Copy link
Contributor

@edalzell edalzell commented Jul 9, 2024

Matching the canManagePublishState from core and replicating this PR: statamic/cms#10424

@edalzell edalzell changed the title Add Publish State permission [7.x] Add Publish State permission Jul 9, 2024
@edalzell
Copy link
Contributor Author

edalzell commented Jul 9, 2024

@duncanmcclean let's talk about this one, as I believe we'd need a migration script otherwise it's breaking.

@edalzell edalzell marked this pull request as draft July 9, 2024 22:50
@duncanmcclean
Copy link
Member

duncanmcclean commented Jul 10, 2024

let's talk about this one, as I believe we'd need a migration script otherwise it's breaking.

Yes, we'll need an upgrade script for this. We've done permission-related update scripts in Core in the past, we could likely copy one of these.

It'll only affect permisisons for resources where "publish states" are enabled.

src/ServiceProvider.php Outdated Show resolved Hide resolved
resources/js/components/Publish/PublishForm.vue Outdated Show resolved Hide resolved
@edalzell edalzell marked this pull request as ready for review July 10, 2024 18:58
@edalzell edalzell requested a review from duncanmcclean July 10, 2024 19:05
@duncanmcclean duncanmcclean merged commit ae69128 into statamic-rad-pack:7.x Jul 12, 2024
1 of 6 checks passed
Copy link

Released as part of v7.6.0.

@edalzell edalzell deleted the fix/revision-publish-permission branch July 18, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants