Filter and sort via Meilisearch #36
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be great to get some test coverage for this as it feels potentially breaking. From scanning the code i think it will also only handle 1-level deep where's, whereas currently we can handle nested where's. |
helloiamlukas
changed the title
where
|
Once #40 merges could you update this with some test coverage for the current behaviour (standard searching on all fields as its done through the CP) and your new additions so we can ensure that nothing breaks. |
|
Could really do with this being merged in! |
|
@KieMaverick as indicated, theres no test coverage and it breaks current behaviour so that cant happen as things stand. |
|
@KieMaverick Feel free to update this pull request. I currently have not so much time working on it, would appreciate the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now the
whereclauses were applied after the search results have been returned.This pull request uses the built in
filterquery of Meilisearch to apply thewhereclauses.It is build on top of this: #35