Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filter all out falsey values #8

Merged
merged 1 commit into from
Sep 8, 2017
Merged

filter all out falsey values #8

merged 1 commit into from
Sep 8, 2017

Conversation

ivancuric
Copy link

No description provided.

@stasm stasm merged commit 9267a6b into stasm:master Sep 8, 2017
@stasm
Copy link
Owner

stasm commented Sep 8, 2017

Thanks!

@stasm
Copy link
Owner

stasm commented Sep 8, 2017

I realized that in case when a number is interpolated and its value is 0, we probably still want to show it :) I restricted the filter to only rejecting null and undefined: 5c57686.

@ivancuric
Copy link
Author

Makes sense, didn't think of that edge case.

@ivancuric ivancuric deleted the filter-falsey branch September 9, 2017 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivancuric @stasm