Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip reencoding compatible video streams #4783

Merged
merged 2 commits into from
May 8, 2024

Conversation

HookedBehemoth
Copy link
Contributor

@HookedBehemoth HookedBehemoth commented Apr 24, 2024

Since MP4 already supports h264 and webm already supports vp8 & vp9 pretty much everywhere, reencoding them can be skipped. Tested on my own files. When seeking, sometimes audio cuts out for a second as -c:v copy only works on full chunks.

I have never used GO before and the change to the go.sum file happened through one of the setup commands. I'll remove it if you don't want that in the tree.

@WithoutPants WithoutPants added the improvement Something needed tweaking. label May 3, 2024
@WithoutPants WithoutPants added this to the Version 0.26.0 milestone May 3, 2024
@WithoutPants WithoutPants merged commit 9cc26f7 into stashapp:develop May 8, 2024
2 checks passed
halkeye pushed a commit to halkeye/stash that referenced this pull request Sep 1, 2024
* skip reencoding compatible video streams
* don't attempt copy on transcode with resize
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something needed tweaking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants