Fix crash on blank aliases/urls #4344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halkeye
pushed a commit
to halkeye/stash
that referenced
this pull request
Sep 1, 2024
* Fix crash on blank alias/url * Fix StringListInput clear issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the crash described in #4338. An error message of "x must not be blank" is now shown if any inputs are blank.
And then a fix for an issue I found while testing with the
StringListInputcomponent: if you get yourself into this situation belowthen deleting the "c" gets you here
at which point typing a character into the bottom input will actually add it to the middle input instead.
Fixes #4338