Fix scene merge dialog (#3466)

* Handle bad savedFilterIds * Fix scene merge dialog
stashapp · Feb 22, 2023 · d0f30eb · d0f30eb
1 parent 87e74d1
commit d0f30eb
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/ui/v2.5/src/components/FrontPage/FrontPageConfig.tsx b/ui/v2.5/src/components/FrontPage/FrontPageConfig.tsx
@@ -243,7 +243,8 @@ const ContentRow: React.FC<IFilterRowProps> = (props: IFilterRowProps) => {
       case "SavedFilter":
         const savedFilter = props.allSavedFilters.find(
           (f) =>
-            f.id === (props.content as ISavedFilterRow).savedFilterId.toString()
+            f.id ===
+            (props.content as ISavedFilterRow).savedFilterId?.toString()
         );
         if (!savedFilter) return "";
         return filterTitle(intl, savedFilter);
@@ -337,7 +338,10 @@ export const FrontPageConfig: React.FC<IFrontPageConfigProps> = ({
   }
 
   const existingSavedFilterIDs = currentContent
-    .filter((f) => f.__typename === "SavedFilter")
+    .filter(
+      (f) =>
+        f.__typename === "SavedFilter" && (f as ISavedFilterRow).savedFilterId
+    )
     .map((f) => (f as ISavedFilterRow).savedFilterId.toString());
 
   function addSavedFilter(content?: FrontPageContent) {

diff --git a/ui/v2.5/src/components/Scenes/SceneMergeDialog.tsx b/ui/v2.5/src/components/Scenes/SceneMergeDialog.tsx
@@ -1,4 +1,4 @@
-import { Form, Col, Row, Button, FormControl, Modal } from "react-bootstrap";
+import { Form, Col, Row, Button, FormControl } from "react-bootstrap";
 import React, { useCallback, useEffect, useMemo, useState } from "react";
 import * as GQL from "src/core/generated-graphql";
 import { Icon } from "../Shared/Icon";
@@ -29,6 +29,7 @@ import {
 } from "./SceneDetails/SceneScrapeDialog";
 import { galleryTitle } from "src/core/galleries";
 import { RatingSystem } from "src/components/Shared/Rating/RatingSystem";
+import { ModalComponent } from "../Shared/Modal";
 
 interface IStashIDsField {
   values: GQL.StashId[];
@@ -655,7 +656,7 @@ export const SceneMergeModal: React.FC<ISceneMergeModalProps> = ({
   }
 
   return (
-    <Modal
+    <ModalComponent
       show={show}
       header={title}
       icon={faSignInAlt}
@@ -723,6 +724,6 @@ export const SceneMergeModal: React.FC<ISceneMergeModalProps> = ({
           </Form.Group>
         </div>
       </div>
-    </Modal>
+    </ModalComponent>
   );
 };