Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mindgeek API (Local + Marker support) #738

Merged
merged 14 commits into from
Nov 14, 2021
Merged

Conversation

Belleyy
Copy link
Contributor

@Belleyy Belleyy commented Oct 3, 2021

  • Copy official marker. (You will need to have the main tag)
    It could lead to incorrect marker because sometimes the time is off. (File with different duration that the official, official marker are just incorrect 🤷‍♂️ ). I have a file that is 20min off than the official 🤔

  • Use local json if you have them and the scene url fail

@Belleyy Belleyy marked this pull request as ready for review October 3, 2021 15:41
@bnkai
Copy link
Collaborator

bnkai commented Oct 6, 2021

I think (haven't verified that) that all scenes that have timeTags also have the scene duration in seconds mediabook.length
You could check for existence of the timeTags (like you do now) and then compare the duration from the official mediabook file to the one in the stash db. If the duration is off by a fixed amount then dont apply any markers

@bnkai bnkai added the enhancement New feature or request label Oct 6, 2021
@Belleyy
Copy link
Contributor Author

Belleyy commented Oct 7, 2021

I think (haven't verified that) that all scenes that have timeTags also have the scene duration in seconds mediabook.length You could check for existence of the timeTags (like you do now) and then compare the duration from the official mediabook file to the one in the stash db. If the duration is off by a fixed amount then dont apply any markers

Oh yea, i thought that this length was the trailer because the other info below is for trailer. But i checked and it's probably the real length.
Some scene have this set to 0/1 😞 What i should when this happens, create the marker or ignore it, or create a new variable to allow create marker without caring about mediabook.length.
Since marker is a specific moment, the difference need to be real close ? (5 sec maybe ?)

@bnkai
Copy link
Collaborator

bnkai commented Oct 7, 2021

Yeah i am not sure either.
If the length is close enough or equal marker should be ok. If the difference is too much i dont think the scraped markers would be useful. As for 0/1 it could be either way. Imo anything you choose is fine

@Belleyy
Copy link
Contributor Author

Belleyy commented Nov 2, 2021

Updated with different variable to control Marker creating, the difference is 10sec (Between MindGeek vs Stash) should be good enough i think.

@bnkai
Copy link
Collaborator

bnkai commented Nov 14, 2021

Merging with minimal testing though as not many scenes seem to have timetags..

@bnkai bnkai merged commit 6416476 into stashapp:master Nov 14, 2021
jackchack pushed a commit to jackchack/CommunityScrapers that referenced this pull request Mar 5, 2022
@Belleyy Belleyy deleted the patch-30 branch May 24, 2022 20:31
litcum22 pushed a commit to litcum22/CommunityScrapers that referenced this pull request Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants