Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the names of assert_eq opcodes #343

Merged

Conversation

ohad-nir-starkware
Copy link
Collaborator

@ohad-nir-starkware ohad-nir-starkware commented Jan 10, 2025

This change is Reviewable

@ohad-nir-starkware ohad-nir-starkware force-pushed the ohadn/update-opcodes-names-assert_eq_opcode branch from 95fdb02 to 93cce24 Compare January 14, 2025 11:06
Copy link
Contributor

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 18 files at r1, 12 of 12 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @DavidLevitGurevich and @shaharsamocha7)

Copy link
Collaborator Author

@ohad-nir-starkware ohad-nir-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 18 files at r1, 12 of 12 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @DavidLevitGurevich and @shaharsamocha7)

@ohad-nir-starkware ohad-nir-starkware merged commit ef9b34e into main Jan 14, 2025
7 checks passed
@ohad-nir-starkware ohad-nir-starkware deleted the ohadn/update-opcodes-names-assert_eq_opcode branch January 14, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants