update the names of add_ap opcodes #341
Conversation
![semgrep-code-starkware-libs[bot]](https://avatars.githubusercontent.com/u/59333826?s=60&v=4){kind=small}
| let (mut trace, mut lookup_data, mut sub_components_inputs) = unsafe { | ||
| ( | ||
| ComponentTrace::<N_TRACE_COLUMNS>::uninitialized(log_size), | ||
| LookupData::uninitialized(log_n_packed_rows), | ||
| SubComponentInputs::uninitialized(log_size), | ||
| ) | ||
| }; |
There was a problem hiding this comment.
ohad-nir-starkware
force-pushed
the
ohadn/update-opcodes-names-add_ap_opcode
branch
3 times, most recently
from
eedc13c to
3a4c6c0
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 21 files reviewed, 1 unresolved discussion (waiting on @semgrep-code-starkware-libs[bot] and @shaharsamocha7)
| let (mut trace, mut lookup_data, mut sub_components_inputs) = unsafe { | ||
| ( | ||
| ComponentTrace::<N_TRACE_COLUMNS>::uninitialized(log_size), | ||
| LookupData::uninitialized(log_n_packed_rows), | ||
| SubComponentInputs::uninitialized(log_size), | ||
| ) | ||
| }; |
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 0 of 21 files reviewed, 2 unresolved discussions (waiting on @DavidLevitGurevich, @ohad-nir-starkware, @semgrep-code-starkware-libs[bot], and @shaharsamocha7)
stwo_cairo_prover/crates/prover/src/cairo_air/opcodes_air.rs line 99 at r2 (raw file):
self.add_ap.iter().map(|c| c.log_sizes()), self.add_ap_op_1_base_fp.iter().map(|c| c.log_sizes()), self.add_ap_imm.iter().map(|c| c.log_sizes()),
sort alphabetically everywhere,
you can do this with ctrl+shift+p+"sort ascending"
Code quote:
self.add_ap_op_1_base_fp.iter().map(|c| c.log_sizes()),
self.add_ap_imm.iter().map(|c| c.log_sizes()),
ohad-nir-starkware
force-pushed
the
ohadn/update-opcodes-names-add_ap_opcode
branch
from
3a4c6c0 to
294c250
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 21 files reviewed, 2 unresolved discussions (waiting on @DavidLevitGurevich, @ohad-starkware, @semgrep-code-starkware-libs[bot], and @shaharsamocha7)
stwo_cairo_prover/crates/prover/src/cairo_air/opcodes_air.rs line 99 at r2 (raw file):
Previously, ohad-starkware (Ohad) wrote…
sort alphabetically everywhere,
you can do this with ctrl+shift+p+"sort ascending"
that is a nontrivial amount of work and I would have to repeat that 7 times.
the order might change as each PR merges, so I rather just do it once on the 7th PR or even make an 8th PR for that.
|
Previously, ohad-nir-starkware (Ohad Nir) wrote…
alright |
There was a problem hiding this comment.
Reviewed 6 of 21 files at r1, 3 of 5 files at r2, 6 of 8 files at r3, all commit messages.
Reviewable status: 15 of 21 files reviewed, 1 unresolved discussion (waiting on @DavidLevitGurevich, @semgrep-code-starkware-libs[bot], and @shaharsamocha7)
There was a problem hiding this comment.
Reviewed 2 of 21 files at r1, 1 of 5 files at r2, 2 of 8 files at r3.
Reviewable status: 20 of 21 files reviewed, 1 unresolved discussion (waiting on @DavidLevitGurevich, @semgrep-code-starkware-libs[bot], and @shaharsamocha7)
There was a problem hiding this comment.
Dismissed @semgrep-code-starkware-libs[bot] from a discussion.
Reviewable status: 20 of 21 files reviewed, all discussions resolved (waiting on @DavidLevitGurevich and @shaharsamocha7)
There was a problem hiding this comment.
Reviewed 8 of 21 files at r1, 5 of 5 files at r2, 8 of 8 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @DavidLevitGurevich and @shaharsamocha7)
ohad-nir-starkware
deleted the
ohadn/update-opcodes-names-add_ap_opcode
branch
|
sorry missed that |
This change is