Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padding example #334

Draft
wants to merge 1 commit into
base: 01-07-generate_enabler_column
Choose a base branch
from

Conversation

shaharsamocha7
Copy link
Contributor

@shaharsamocha7 shaharsamocha7 commented Jan 9, 2025

This change is Reviewable

Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ohad-starkware
Copy link
Contributor

stwo_cairo_prover/crates/prover/src/components/ret_opcode/prover.rs line 362 at r1 (raw file):

    {
        let log_size = std::cmp::max(self.n_calls.next_power_of_two().ilog2(), LOG_N_LANES);
        let padding_col = gen_padding_column(log_size as usize, self.n_calls).into_simd_vec();

Same as seq, you can generate it on the fly and avoid the malloc. will also save some code, and you can use that function in the generate_padding_column function, where you need a value that is partially 0 and partially 1.

@shaharsamocha7 shaharsamocha7 force-pushed the 01-07-generate_enabler_column branch from 748e324 to 4886ee3 Compare January 9, 2025 12:50
Copy link
Contributor

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants