Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added BoolIntoFelt252. #3667

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Added BoolIntoFelt252. #3667

merged 1 commit into from
Jul 13, 2023

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Jul 12, 2023 •
edited by spapinistarkware
Loading

This change is Reviewable

@orizi orizi requested a review from yuvalsw July 12, 2023 12:58
@orizi orizi enabled auto-merge July 12, 2023 12:58
@orizi orizi requested a review from gilbens-starkware July 12, 2023 14:54
gilbens-starkware
gilbens-starkware approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yuvalsw)

@orizi orizi added this pull request to the merge queue Jul 13, 2023
Merged via the queue into main with commit d4e9887 Jul 13, 2023
@orizi orizi deleted the oriz/bool-into-felt252 branch July 13, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilbens-starkware gilbens-starkware gilbens-starkware approved these changes

@yuvalsw yuvalsw Awaiting requested review from yuvalsw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orizi @gilbens-starkware