Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: StarkGate 2.0 function/event reference, architecture topic, procedures #922

Merged
merged 19 commits into from
Dec 19, 2023

Conversation

stoobie
Copy link
Collaborator

@stoobie stoobie commented Nov 7, 2023

Description of the Changes

This PR contains new developer content for StarkGate 2.0. This PR should only be merged to dev on or around the release of StarkGate 2.0.

PR Preview URL

StarkGate bridge developer’s guide

Check List

  • Changes have been done against dev branch, and PR does not conflict
  • PR title follows the convention: <docs/feat/fix/chore>(optional scope): <description>, e.g: fix: minor typos in code

This change is Reviewable

Copy link

github-actions bot commented Nov 7, 2023

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-922/documentation/ .

1 similar comment
Copy link

github-actions bot commented Nov 7, 2023

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-922/documentation/ .

@stoobie stoobie marked this pull request as draft November 7, 2023 15:53
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-922/documentation/ .

@stoobie stoobie changed the base branch from dev to master November 28, 2023 07:45
@stoobie stoobie marked this pull request as ready for review December 4, 2023 09:50
Copy link

github-actions bot commented Dec 4, 2023

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-922/documentation/ .

1 similar comment
Copy link

github-actions bot commented Dec 4, 2023

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-922/documentation/ .

Copy link

github-actions bot commented Dec 4, 2023

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-922/documentation/ .

Copy link

github-actions bot commented Dec 4, 2023

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-922/documentation/ .

3 similar comments
Copy link

github-actions bot commented Dec 4, 2023

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-922/documentation/ .

Copy link

github-actions bot commented Dec 7, 2023

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-922/documentation/ .

Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-922/documentation/ .

stoobie and others added 11 commits December 19, 2023 14:49
…ral content. (#886)

* Adding a new topic with functions for StarkGate.

* Added blockToken

* Added deactivateToken

* Added more functions.

* Added getWithdrawalBridges.

* Renamed token-bridge.adoc to starkgate-bridge.adoc. Added entries to .htaccess.

* Add L2 functions.

* Added params to addExistingBridge.

* SME comment

* Minor fixes.

* Added more functions.

* More edits.

* Add getStatus

* Add Cancelling a deposit.

* Added deposit and depositReclaim

* Add table-striping to description lists for parameters and returns.

* Adding types to parameters.

* Adding event to `Deposit`

* Add depositWithMessage

* Updates to overview.

* Adding `depositWithMessage*` functions.

* SME comments

* depositWithMessage* functions.

* Moved desc of Manager and Registry to top of section.

* SME comments

* SME comments

* SME comments

* Added new topic: StarkGate architecture.

* Changed name of file from stargate_dev_reference.adoc to starkgate_function_reference.adoc; Removed info on adding a custom bridge from starkgate-adding_a_token.adoc.

* Updated starkgate_architecture.adoc.

* SME comments, cleaning up scattered links.

* Edit xref text for deposit function and event

* Edited name of reference doc

* Fixed broken xref.

* Added list of functions in each contract.

* Updated architecture topic.

* Removed the section on the Manager and the Registry. I don't think that this is helpful.

* Added AsciiDoc role to function heading in prep for adding style to make heading clearer.

* Updates to Architecture topic based on SME engineering and product feedback.

* Updates to function reference based on SME comments.

* Fixed typo.

* Added Visibility header.

* Consistency edits.

* Consistency edits.

---------

Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com>
…patibility (#933)

* Add `on_receive` function interface.

* Add snippet_backwards_compatibiity_note.adoc with a note about backwards compatibility. Put note in:
starkgate_architecture.adoc
starkgate_function_reference.adoc
starkgate-bridge.adoc

* Started to add tagged regions for event descriptions to use same text as parameter descriptions.

* SME comments.

* Adding tagged regions for event params.

* Adding tagged regions for event params.

* Added concept topic explaining the depositWithMessage flow.

* SME comment

* SME Comments for `on_receive`

* Updated concept topic for `depositWithMessage`
…ral content. (#886)

* Adding a new topic with functions for StarkGate.

* Added blockToken

* Added deactivateToken

* Added more functions.

* Added getWithdrawalBridges.

* Renamed token-bridge.adoc to starkgate-bridge.adoc. Added entries to .htaccess.

* Add L2 functions.

* Added params to addExistingBridge.

* SME comment

* Minor fixes.

* Added more functions.

* More edits.

* Add getStatus

* Add Cancelling a deposit.

* Added deposit and depositReclaim

* Add table-striping to description lists for parameters and returns.

* Adding types to parameters.

* Adding event to `Deposit`

* Add depositWithMessage

* Updates to overview.

* Adding `depositWithMessage*` functions.

* SME comments

* depositWithMessage* functions.

* Moved desc of Manager and Registry to top of section.

* SME comments

* SME comments

* SME comments

* Added new topic: StarkGate architecture.

* Changed name of file from stargate_dev_reference.adoc to starkgate_function_reference.adoc; Removed info on adding a custom bridge from starkgate-adding_a_token.adoc.

* Updated starkgate_architecture.adoc.

* SME comments, cleaning up scattered links.

* Edit xref text for deposit function and event

* Edited name of reference doc

* Fixed broken xref.

* Added list of functions in each contract.

* Updated architecture topic.

* Removed the section on the Manager and the Registry. I don't think that this is helpful.

* Added AsciiDoc role to function heading in prep for adding style to make heading clearer.

* Updates to Architecture topic based on SME engineering and product feedback.

* Updates to function reference based on SME comments.

* Fixed typo.

* Added Visibility header.

* Consistency edits.

* Consistency edits.

---------

Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com>
…patibility (#933)

* Add `on_receive` function interface.

* Add snippet_backwards_compatibiity_note.adoc with a note about backwards compatibility. Put note in:
starkgate_architecture.adoc
starkgate_function_reference.adoc
starkgate-bridge.adoc

* Started to add tagged regions for event descriptions to use same text as parameter descriptions.

* SME comments.

* Adding tagged regions for event params.

* Adding tagged regions for event params.

* Added concept topic explaining the depositWithMessage flow.

* SME comment

* SME Comments for `on_receive`

* Updated concept topic for `depositWithMessage`
* Add table with list of bridged tokens

* Removed TVL limitations from StarkGate overview.
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-922/documentation/ .

Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-922/documentation/ .

@stoobie stoobie merged commit beb89fb into master Dec 19, 2023
2 checks passed
@stoobie stoobie deleted the starkgatev2.0 branch December 19, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant