fix: Fix example in emit_events #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1169/documentation/ . |
|
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1169/documentation/ . |
0xLucqs
approved these changes
Mar 7, 2024
xiaolou86
pushed a commit
to xiaolou86/starknet-docs
that referenced
this pull request
Apr 7, 2024
* Fix example in emit_events * Update event example in starknet-events.adoc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
This PR fixes #1124.
The syscall emit_event example is incorrect, and the problem noted in num 2 also applies here.
https://docs.starknet.io/documentation/architecture_and_concepts/Smart_Contracts/starknet-events/
The above code emits an event with two keys, the strings “status” and “deposit”
The code shown actually uses “key” and “deposit” as keys
PR Preview URL
Events
emit_event
Check List
<docs/feat/fix/chore>(optional scope): <description>, e.g:fix: minor typos in codeThis change is