Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update transaction-life-cycle.adoc with a note on rejected transactions #1141

Merged
merged 6 commits into from
Feb 22, 2024
Merged

Update transaction-life-cycle.adoc with a note on rejected transactions #1141

merged 6 commits into from
Feb 22, 2024

Conversation

odednaor
Copy link
Collaborator

@odednaor odednaor commented Feb 21, 2024 •
edited by stoobie
Loading

Description of the Changes

Added a note that if a transaction is rejected, then another transaction with the same transaction hash cannot be sent.

PR Preview URL

https://starknet-io.github.io/starknet-docs/pr-1141/documentation/architecture_and_concepts/Network_Architecture/transaction-life-cycle/

Check List

  • Changes have been done against main branch, and PR does not conflict
  • PR title follows the convention: <docs/feat/fix/chore>(optional scope): <description>, e.g: fix: minor typos in code

@odednaor odednaor requested review from stoobie and ArielElp February 21, 2024 15:45
@github-actions GitHub Actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1141/documentation/ .

@stoobie
Update components/Starknet/modules/architecture_and_concepts/pages/Ne…
97e93b6 
…twork_Architecture/transaction-life-cycle.adoc
@github-actions GitHub Actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1141/documentation/ .

@github-actions GitHub Actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1141/documentation/ .

stoobie
stoobie requested changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@stoobie stoobie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remving plus (+) signs.

...net/modules/architecture_and_concepts/pages/Network_Architecture/transaction-life-cycle.adoc Outdated Show resolved Hide resolved
...net/modules/architecture_and_concepts/pages/Network_Architecture/transaction-life-cycle.adoc Outdated Show resolved Hide resolved
...net/modules/architecture_and_concepts/pages/Network_Architecture/transaction-life-cycle.adoc Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1141/documentation/ .

@github-actions GitHub Actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1141/documentation/ .

@odednaor @stoobie
Apply suggestions from code review
f417937 
Co-authored-by: Steve Goodman <39279277+stoobie@users.noreply.github.com>
@odednaor
Copy link
Collaborator Author

lgtm

@github-actions GitHub Actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1141/documentation/ .

stoobie
stoobie approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@stoobie stoobie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stoobie stoobie merged commit 0629388 into main Feb 22, 2024
2 of 3 checks passed
@stoobie stoobie deleted the odednaor-patch-1 branch February 22, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stoobie stoobie stoobie approved these changes

@ArielElp ArielElp Awaiting requested review from ArielElp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odednaor @stoobie