Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Add Withdrawal limit to StarkGate architecture #1140

Merged
merged 5 commits into from
Feb 22, 2024

Conversation

stoobie
Copy link
Collaborator

@stoobie stoobie commented Feb 21, 2024

Description of the Changes

New section on StarkGate withdrawal limit

PR Preview URL

Withdrawal limit

Check List

  • Changes have been done against main branch, and PR does not conflict
  • PR title follows the convention: <docs/feat/fix/chore>(optional scope): <description>, e.g: fix: minor typos in code

@stoobie stoobie requested a review from natan-granit February 21, 2024 15:25
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1140/documentation/ .


By default, StarkGate imposes no limit on withdrawals. However, in order tBy default, StarkGate imposes no limit on withdrawals. However, in order to mitigate risks associated with critical vulnerabilities that could result in the loss of user funds, StarkGate can enable a withdrawal limit.

If a serious security issue arises, the security agent in the StarkGate contract can limit withdrawals to 5% of the Total Value Locked (TVL) per day for any affected token by calling the `enableWithdrawalLimit()` function in the StarkGate contract. A dedicated team can then investigate and resolve the issue.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@natan-granit I need a link to the function in the contract.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1140/documentation/ .

@stoobie stoobie force-pushed the steve/starkgate/withdrawal_limit branch from 11f55aa to 3b20e7e Compare February 21, 2024 16:19
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1140/documentation/ .

package.json Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1140/documentation/ .

Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1140/documentation/ .

Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1140/documentation/ .

Copy link
Collaborator

@natan-granit natan-granit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@natan-granit natan-granit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stoobie stoobie merged commit 464aa09 into main Feb 22, 2024
2 of 3 checks passed
@stoobie stoobie deleted the steve/starkgate/withdrawal_limit branch February 22, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants