-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ignore fee token contract is the fee formula #1123
Conversation
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1123/documentation/ . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ArielElp Looks good except for one sentence. PTAL at my suggestion.
...nts/Starknet/modules/architecture_and_concepts/pages/Network_Architecture/fee-mechanism.adoc
Outdated
Show resolved
Hide resolved
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1123/documentation/ . |
Co-authored-by: Steve Goodman <39279277+stoobie@users.noreply.github.com>
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1123/documentation/ . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ArielElp One tiny change.
...nts/Starknet/modules/architecture_and_concepts/pages/Network_Architecture/fee-mechanism.adoc
Outdated
Show resolved
Hide resolved
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1123/documentation/ . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of the Changes
Adjusting the fee formula to account for the fee token address.
PR Preview URL
After you push a commit to this PR, a preview is built and a URL to the root of the preview appears in the comment feed.
Paste here the specific URL(s) of the content that this PR addresses.
Check List
<docs/feat/fix/chore>(optional scope): <description>
, e.g:fix: minor typos in code
This change is