Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Describe contract nonce. Changed title to Contract classes and instances in contract-classes.adoc #1099

Merged
merged 4 commits into from
Feb 8, 2024

Conversation

stoobie
Copy link
Collaborator

@stoobie stoobie commented Jan 31, 2024

Description of the Changes

Changed title to Contract classes and instances in contract-classes.adoc, and addresses #1098.

PR Preview URL

Contract classes and instances

Check List

  • Changes have been done against main branch, and PR does not conflict
  • PR title follows the convention: <docs/feat/fix/chore>(optional scope): <description>, e.g: fix: minor typos in code

This change is Reviewable

Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1099/documentation/ .

Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1099/documentation/ .

Copy link

github-actions bot commented Feb 7, 2024

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1099/documentation/ .

@stoobie stoobie requested a review from odednaor February 7, 2024 15:47
@stoobie stoobie changed the title fix: Changed title to Contract classes and instances in contract-classes.adoc docs: Describe contract nonce. Changed title to Contract classes and instances in contract-classes.adoc Feb 7, 2024
Copy link
Collaborator

@odednaor odednaor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some minor suggestions.

…art_Contracts/contract-classes.adoc

Co-authored-by: odednaor <odednaor@gmail.com>
Copy link

github-actions bot commented Feb 8, 2024

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1099/documentation/ .

Copy link
Collaborator

@odednaor odednaor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stoobie stoobie merged commit a568ec7 into main Feb 8, 2024
2 of 3 checks passed
@stoobie stoobie deleted the steve/contract_classes/title_casing branch February 8, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants