Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version_notes.adoc with v0.13 versions on testnets #1023

Merged
merged 7 commits into from
Dec 14, 2023

Conversation

odednaor
Copy link
Collaborator

@odednaor odednaor commented Dec 13, 2023

Description of the Changes

Release notes of Starknet v0.13, and update versions tables on Starknet, Cairo, and Sierra version numbers.

PR Preview URL

https://starknet-io.github.io/starknet-docs/pr-1023/documentation/starknet_versions/version_notes/

Check List

  • Changes have been done against master branch, and PR does not conflict
  • PR title follows the convention: <docs/feat/fix/chore>(optional scope): <description>, e.g: fix: minor typos in code

This change is Reviewable

@odednaor odednaor requested review from stoobie and ArielElp December 13, 2023 11:24
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1023/documentation/ .

Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1023/documentation/ .

@odednaor
Copy link
Collaborator Author

@stoobie What should we do with the v0.13 release notes on the upcoming versions page while mainnet is not yet upgraded to v0.13?

Copy link
Collaborator

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @odednaor and @stoobie)


components/Starknet/modules/starknet_versions/pages/version_notes.adoc line 32 at r1 (raw file):

** Fee payment in STRK
** Reserved fields for future features, such as volition and payment master
* `get_block` API: Rename the `gas_price` field to `eth_l1_gas_price` and add a new field `strk_l1_gas_price` (this applies to old blocks as well)

Replace this point with a link to v0.6.0 spec https://github.com/starkware-libs/starknet-specs/releases/tag/v0.6.0


components/Starknet/modules/starknet_versions/pages/version_notes.adoc line 33 at r1 (raw file):

** Reserved fields for future features, such as volition and payment master
* `get_block` API: Rename the `gas_price` field to `eth_l1_gas_price` and add a new field `strk_l1_gas_price` (this applies to old blocks as well)
* Update Sierra version used in Starknet to `1.4.0` (introduced in crate version `v2.4.0` of the cairo package)

replace this with a link here https://community.starknet.io/t/cairo-v2-4-0-is-out/109275


components/Starknet/modules/starknet_versions/pages/version_notes.adoc line 35 at r1 (raw file):

* Update Sierra version used in Starknet to `1.4.0` (introduced in crate version `v2.4.0` of the cairo package)
* Improved performance of `secp256k1_mul` and `secp256r1_mul` syscalls

we need a another bullet point about cost reduction: computation cost is reduced by roughly 2x (cairo steps and builtins), DA cost is reduced by roughly 10%.

@stoobie stoobie requested a review from ArielElp December 13, 2023 14:55
Copy link
Collaborator

@stoobie stoobie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 7 unresolved discussions (waiting on @ArielElp and @odednaor)


components/Starknet/modules/starknet_versions/pages/version_notes.adoc line 35 at r1 (raw file):

Previously, ArielElp wrote…

we need a another bullet point about cost reduction: computation cost is reduced by roughly 2x (cairo steps and builtins), DA cost is reduced by roughly 10%.

PTAL.


components/Starknet/modules/starknet_versions/pages/version_notes.adoc line 32 at r2 (raw file):

** Fee payment in STRK
** Reserved fields for future features, such as volition and payment master
* `get_block` API: Rename the `gas_price` field to `eth_l1_gas_price` and add a new field `strk_l1_gas_price` (this applies to old blocks as well)

Suggestion:

`get_block` API: The `gas_price` field is replaced by the `eth_l1_gas_price` and `strk_l1_gas_price` fields. This change applies also to existing blocks. For more information on the new fields, see the link:https://github.com/starkware-libs/starknet-specs/releases/tag/v0.6.0[JSON RPC API Spec on Github]

components/Starknet/modules/starknet_versions/pages/version_notes.adoc line 33 at r2 (raw file):

** Reserved fields for future features, such as volition and payment master
* `get_block` API: Rename the `gas_price` field to `eth_l1_gas_price` and add a new field `strk_l1_gas_price` (this applies to old blocks as well)
* Update Sierra version used in Starknet to `1.4.0` (introduced in crate version `v2.4.0` of the cairo package)

Suggestion:

* Sierra v1.4.0. This new version of Sierra is part of Crate v2.4.0, in the Cairo 2.4.0 package.

components/Starknet/modules/starknet_versions/pages/version_notes.adoc line 34 at r2 (raw file):

* `get_block` API: Rename the `gas_price` field to `eth_l1_gas_price` and add a new field `strk_l1_gas_price` (this applies to old blocks as well)
* Update Sierra version used in Starknet to `1.4.0` (introduced in crate version `v2.4.0` of the cairo package)
* Improved performance of `secp256k1_mul` and `secp256r1_mul` syscalls

We don't document these syscalls. Should we?


components/Starknet/modules/starknet_versions/pages/version_notes.adoc line 34 at r2 (raw file):

* `get_block` API: Rename the `gas_price` field to `eth_l1_gas_price` and add a new field `strk_l1_gas_price` (this applies to old blocks as well)
* Update Sierra version used in Starknet to `1.4.0` (introduced in crate version `v2.4.0` of the cairo package)
* Improved performance of `secp256k1_mul` and `secp256r1_mul` syscalls

Suggestion:

* Improved performance of `secp256k1_mul` and `secp256r1_mul` syscalls
* Computation cost is reduced approximately 200% as a result of reduced Cairo steps and increased use of builtins. L1 data availability cost is reduced by approximtately 10%.

Copy link
Collaborator

@stoobie stoobie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@odednaor I added some comments and suggestions in Reviewable.

@stoobie
Copy link
Collaborator

stoobie commented Dec 14, 2023

@stoobie What should we do with the v0.13 release notes on the upcoming versions page while mainnet is not yet upgraded to v0.13?

@odednaor Well, the info on that page is more detailed than the info in this PR. I thought to just move that info into the Release notes and remove that page for now. We clearly state the status on testnet and Mainnet.

Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1023/documentation/ .

Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1023/documentation/ .

Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1023/documentation/ .

@stoobie stoobie merged commit 9d206ea into master Dec 14, 2023
2 of 3 checks passed
@stoobie stoobie deleted the odednaor-patch-1 branch December 14, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants