Skip to content

Commit

Permalink
🎨 启用linter
Browse files Browse the repository at this point in the history
  • Loading branch information
Ink-33 committed May 30, 2021
1 parent b25fe2d commit 580fd16
Show file tree
Hide file tree
Showing 7 changed files with 142 additions and 4 deletions.
24 changes: 24 additions & 0 deletions .github/workflows/golint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: Lint

on: [push]

jobs:
golangci:
name: lint_golangci-lint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2.3.4

- name: golangci-lint
uses: golangci/golangci-lint-action@v2.5.2
with:
version: latest

- name: Commit back
continue-on-error: true
run: |
git config --local user.name 'github-actions[bot]'
git config --local user.email '41898282+github-actions[bot]@users.noreply.github.com'
git add --all
git commit -m "🎨 改进代码样式"
git push
20 changes: 20 additions & 0 deletions .github/workflows/suggester.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
name: Suggester

on: [pull_request]

jobs:
golangci:
name: lint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2.3.4

- name: golangci-lint
uses: golangci/golangci-lint-action@v2.5.2
with:
version: latest

- name: Suggester
uses: reviewdog/action-suggester@v1.0.1
with:
tool_name: golangci-lint
94 changes: 94 additions & 0 deletions .golangci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,94 @@
linters-settings:
errcheck:
ignore: fmt:.*,io/ioutil:^Read.*
ignoretests: true

goimports:
local-prefixes: github.com/Yiwen-Chan/ZeroBot-Plugin

gocritic:
disabled-checks:
- exitAfterDefer

forbidigo:
# Forbid the following identifiers
forbid:
- ^fmt\.Errorf$ # consider errors.Errorf in github.com/pkg/errors

linters:
# please, do not use `enable-all`: it's deprecated and will be removed soon.
# inverted configuration with `enable-all` and `disable` is not scalable during updates of golangci-lint
fast: true
enable:
- bodyclose
- deadcode
- depguard
- dogsled
- dupl
- errcheck
- exportloopref
- exhaustive
#- funlen
#- goconst
- gocritic
#- gocyclo
- gofmt
- goimports
- goprintffuncname
#- gosec
- gosimple
- govet
- ineffassign
- misspell
- nolintlint
- rowserrcheck
- staticcheck
- structcheck
- stylecheck
- typecheck
- unconvert
- unparam
- unused
- varcheck
- whitespace
- prealloc
- predeclared
- asciicheck
- forbidigo
- makezero
- revive
#- interfacer

# don't enable:
# - scopelint
# - gochecknoglobals
# - gocognit
# - godot
# - godox
# - goerr113
# - interfacer
# - maligned
# - nestif
# - testpackage
# - wsl

run:
# default concurrency is a available CPU number.
# concurrency: 4 # explicitly omit this value to fully utilize available resources.
deadline: 5m
issues-exit-code: 1
tests: false

# output configuration options
output:
format: "colored-line-number"
print-issued-lines: true
print-linter-name: true
uniq-by-line: true

issues:
# Fix found issues (if it's supported by the linter)
fix: true
exclude-use-default: false
exclude:
- "Error return value of .((os.)?std(out|err)..*|.*Close|.*Flush|os.Remove(All)?|.*print(f|ln)?|os.(Un)?Setenv). is not check"
1 change: 0 additions & 1 deletion chat/chat.go
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ func init() { // 插件主体
))
return
}

})
zero.OnFullMatch(`群温度`).SetBlock(true).FirstPriority().
Handle(func(ctx *zero.Ctx) {
Expand Down
1 change: 0 additions & 1 deletion chat/learn.go
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,6 @@ func init() {
return
}
})

}

func botPath() string {
Expand Down
3 changes: 2 additions & 1 deletion setutime/pic_searcher.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,10 @@ import (
"strings"
"time"

utils "github.com/Yiwen-Chan/ZeroBot-Plugin/setutime/utils"
zero "github.com/wdvxdr1123/ZeroBot"
"github.com/wdvxdr1123/ZeroBot/message"

utils "github.com/Yiwen-Chan/ZeroBot-Plugin/setutime/utils"
)

func init() { // 插件主体
Expand Down
3 changes: 2 additions & 1 deletion setutime/setu_geter.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,10 @@ import (
"strings"
"time"

"github.com/Yiwen-Chan/ZeroBot-Plugin/setutime/utils"
zero "github.com/wdvxdr1123/ZeroBot"
"github.com/wdvxdr1123/ZeroBot/extension/rate"

"github.com/Yiwen-Chan/ZeroBot-Plugin/setutime/utils"
)

var limit = rate.NewManager(time.Minute*1, 5)
Expand Down

0 comments on commit 580fd16

Please sign in to comment.