Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove typemap and fix io-lifetimes compiler error #3847

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Conversation

nkysg
Copy link
Collaborator

@nkysg nkysg commented Feb 11, 2023

fix io-lifetimes compiler error

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@nkysg nkysg requested a review from welbon February 11, 2023 03:14
@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

Merging #3847 (9052c78) into master (0bb317e) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3847      +/-   ##
==========================================
+ Coverage   54.09%   54.16%   +0.08%     
==========================================
  Files         613      613              
  Lines       67797    67797              
==========================================
+ Hits        36670    36718      +48     
+ Misses      31127    31079      -48     
Flag Coverage Δ
unittests 54.16% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
storage/src/chain_info/mod.rs 87.50% <0.00%> (-1.78%) ⬇️
sync/src/tasks/accumulator_sync_task.rs 96.16% <0.00%> (-1.28%) ⬇️
network-p2p/src/protocol/generic_proto/handler.rs 79.78% <0.00%> (+0.28%) ⬆️
network-p2p/src/request_responses.rs 84.68% <0.00%> (+0.87%) ⬆️
sync/src/tasks/mod.rs 79.12% <0.00%> (+0.89%) ⬆️
...mons/forkable-jellyfish-merkle/src/iterator/mod.rs 77.34% <0.00%> (+1.44%) ⬆️
...rc/protocol/generic_proto/upgrade/notifications.rs 92.23% <0.00%> (+1.88%) ⬆️
sync/src/tasks/mock.rs 89.07% <0.00%> (+2.43%) ⬆️
network/api/src/peer_provider.rs 53.94% <0.00%> (+2.92%) ⬆️
network-rpc/core/src/lib.rs 36.07% <0.00%> (+4.92%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bb317e...9052c78. Read the comment docs.

@nkysg nkysg requested a review from sanlee42 February 11, 2023 03:35
@nkysg nkysg merged commit 55eee20 into master Feb 16, 2023
@nkysg nkysg deleted the remove_traitobject branch February 16, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2019-0039: typemap is Unmaintained [Dev] logger remove traitobject
2 participants