Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor openrpc #3830

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Refactor openrpc #3830

merged 1 commit into from
Jan 10, 2023

Conversation

sanlee42
Copy link
Member

@sanlee42 sanlee42 commented Jan 10, 2023

Remove the patch version of jsonrpc
Use the openrpc-dervice to implement the proc macro

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

Remove the patch version of jsonrpc
Use the openrpc-dervice to implement as the proc macro
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #3830 (8488b3a) into master (34dadaa) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3830      +/-   ##
==========================================
+ Coverage   53.22%   53.26%   +0.05%     
==========================================
  Files         595      595              
  Lines       64702    64702              
==========================================
+ Hits        34431    34460      +29     
+ Misses      30271    30242      -29     
Flag Coverage Δ
unittests 53.26% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rpc/api/src/account/mod.rs 100.00% <100.00%> (ø)
rpc/api/src/chain/mod.rs 100.00% <100.00%> (ø)
rpc/api/src/contract_api.rs 100.00% <100.00%> (ø)
rpc/api/src/debug/mod.rs 100.00% <100.00%> (ø)
rpc/api/src/miner.rs 100.00% <100.00%> (ø)
rpc/api/src/network_manager.rs 100.00% <100.00%> (ø)
rpc/api/src/node/mod.rs 34.79% <100.00%> (ø)
rpc/api/src/node_manager.rs 100.00% <100.00%> (ø)
rpc/api/src/state/mod.rs 100.00% <100.00%> (ø)
rpc/api/src/sync_manager.rs 100.00% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34dadaa...8488b3a. Read the comment docs.

@github-actions
Copy link

Benchmark for d9c3e9f

Click to view benchmark
Test Base PR %
accumulator_append 610.1±29.35µs 611.2±30.22µs +0.18%
block_apply/block_apply_10 796.3±1.13ms 797.5±1.36ms +0.15%
block_apply/block_apply_1000 80.9±0.11s 81.0±0.15s +0.12%
get_with_proof/db_store 36.7±0.21µs 36.5±0.19µs -0.54%
get_with_proof/mem_store 31.6±0.19µs 31.6±0.30µs 0.00%
put_and_commit/db_store/1 95.2±4.90µs 96.3±5.12µs +1.16%
put_and_commit/db_store/10 864.1±40.18µs 858.2±39.54µs -0.68%
put_and_commit/db_store/100 7.4±0.30ms 7.4±0.30ms 0.00%
put_and_commit/db_store/5 442.5±21.89µs 439.4±20.82µs -0.70%
put_and_commit/db_store/50 3.8±0.16ms 3.8±0.16ms 0.00%
put_and_commit/mem_store/1 61.7±5.74µs 61.7±5.63µs 0.00%
put_and_commit/mem_store/10 580.2±49.40µs 577.4±47.29µs -0.48%
put_and_commit/mem_store/100 5.7±0.83ms 5.7±0.84ms 0.00%
put_and_commit/mem_store/5 293.3±25.84µs 291.0±24.97µs -0.78%
put_and_commit/mem_store/50 2.8±0.18ms 2.8±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 6.8±0.41ms 7.2±0.40ms +5.88%
query_block/query_block_in(10)_times(1000) 69.6±2.14ms 69.6±1.06ms 0.00%
query_block/query_block_in(10)_times(10000) 694.5±15.95ms 694.3±7.90ms -0.03%
query_block/query_block_in(1000)_times(100) 997.6±12.06µs 1005.0±13.00µs +0.74%
query_block/query_block_in(1000)_times(1000) 9.9±0.13ms 10.0±0.08ms +1.01%
query_block/query_block_in(1000)_times(10000) 100.0±1.51ms 101.0±1.94ms +1.00%
storage_transaction 1025.9±344.03µs 1002.5±292.35µs -2.28%
vm/transaction_execution/1 910.4±2.70ms 910.8±1.76ms +0.04%
vm/transaction_execution/10 230.2±0.76ms 230.5±0.98ms +0.13%
vm/transaction_execution/20 198.6±1.00ms 198.9±0.70ms +0.15%
vm/transaction_execution/5 303.5±1.84ms 303.7±1.92ms +0.07%
vm/transaction_execution/50 214.6±1.61ms 215.4±1.89ms +0.37%

@sanlee42 sanlee42 merged commit f9ba8b6 into master Jan 10, 2023
@sanlee42 sanlee42 deleted the derive branch January 10, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants